-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ldap authenticator #207
Ldap authenticator #207
Conversation
bba7754
to
7d9e2ce
Compare
7d9e2ce
to
eaa7ebc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let preface this comment by acknowledging this is the very first test_authenticators.py commit, so thanks for adding it!
Possibly for a later PR, but have you thought of mocking the ldap3 code? I have no experience mocking ldap, but there even seems to be some support in ldap3 https://ldap3.readthedocs.io/en/latest/mocking.html
|
Implementation of LDAP authenticator. The authenticator could be configured in .yml file as