Non-blocking LDAP authenticator #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
added a commit
to dmgav/tiled
that referenced
this pull request
Sep 1, 2022
danielballan
added a commit
to bluesky/tiled
that referenced
this pull request
Sep 1, 2022
* ENH: add LDAPAuthenticator * STY: black * Make ldap3 an optional dependency. * Remove global imports. * Refactor imports. * Satisfy isort. * Make LDAP authenticator non-blocking. Ported from bluesky/bluesky-httpserver#38 by @dmgav * Fix missing await. Co-authored-by: Dan Allan <dallan@bnl.gov>
dmgav
force-pushed
the
non-blocking-ldap
branch
from
140c2b4
to
205701d
Compare
dmgav
force-pushed
the
non-blocking-ldap
branch
from
205701d
to
94229db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of non-blocking LDAP authenticator.
Summary of Changes for Release Notes
Fixed
Added
LDAPAuthenticator:connect_timeout,receive_timeout.Changed
LDAPAuthenticatoris now not blocking the server event loop while waiting for the response from the server.LDAPAuthenticatornow works with the pool of LDAP servers. The parameterserver_addressaccepts a string representing a single server or a list of strings representing multiple servers.Removed
How Has This Been Tested?