-
Notifications
You must be signed in to change notification settings - Fork 121
Closed
Labels
accessibilitycoreIssue related to BlueOS-coreIssue related to BlueOS-coreenhancementNew feature or requestNew feature or requesttriageNeeds triage from developersNeeds triage from developersuiUser Interface featureUser Interface feature
Description
Current behaviour
SVGs provided in #2748 and #2760 use hardcoded colour values, both within the SVGs and for the dynamic (light/dark) outline handling. These colours fit the SMS vision, and work well with our default theme, but may not play as nicely with custom themes (see #1938).
Expected or desired behaviour
It would be nice if
- the themes were updated to include the new image colours
- SMS should probably provide names for the defaults
- The new variables could be something like:
outline(dark-mode):#D1EAF1outline(light-mode):#002F45water:#2599D1(almost BR_BLUE?)positive:#4DA383neutral:#FF9A00negative:#FF00DEattention:#FDDC00(almost TETHER_YELLOW?)
- the SVGs were modified to make use of theme-based colours via CSS variables, instead of hardcoded hex codes
- e.g.
style="fill:var(--outline);"(I think?) - This would also remove the current light/dark outline colour switching mechanism, as it would be redundant
- Note that failsafes and motor-reversal both implement the colour switching, so that should at least be consolidated, but can ideally be removed from both
- e.g.
Prerequisites
- I have checked to make sure that a similar request has not already been filed or fixed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
accessibilitycoreIssue related to BlueOS-coreIssue related to BlueOS-coreenhancementNew feature or requestNew feature or requesttriageNeeds triage from developersNeeds triage from developersuiUser Interface featureUser Interface feature