Fix Dockerfile and docker run command for binary build #3761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
This pull request addresses the two issues in the
binaries.mk
file that prevent the proper building of binaries using Docker:Legacy ENV format: The Dockerfile was using the legacy
ENV key value
format, which results in a warning. The newerENV key=value
format is recommended. This PR updates the line to follow the new format: ChangedENV CGO_ENABLED 0
to ENV CGO_ENABLED=0
.Empty section in volume mount path: The
docker run
command was using an invalid volume mount syntax, leading to an "empty section between colons" error. The$(PWD)
macro was replaced with$(shell pwd)
to correctly reference the current working directory.Testing: After making these changes, I was able to successfully build the binaries using the provided instructions without encountering the errors mentioned.