perf: chunk and process playback segments concurrently #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boenshao
force-pushed
the
perf/optmize-playback-list
branch
3 times, most recently
from
ed0caa0
to
2a8b2f1
Compare
boenshao
force-pushed
the
perf/optmize-playback-list
branch
from
2a8b2f1
to
f05f946
Compare
boenshao
force-pushed
the
perf/optmize-playback-list
branch
from
f05f946
to
e95cd74
Compare
boenshao
force-pushed
the
perf/optmize-playback-list
branch
from
e95cd74
to
d39ea20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/listAPI can be a bit slow when there are lots of recordings that need to be processed.The concatenation procedure can be split up and executed concurrently (and even parallelly).
I hard-coded the splits into 4, as most modern platforms have at least 4 cores.
But it's possible to introduce a more sophisticated way to determine the preferred number, either by the number of files or the total size of the files. We can gather the statistics in
os.Walk.Yet I believe the overhead of goroutine is negligible in most cases, so a static strategy is probably alright.
With this patch, on my AlderLake laptop, the response time is about 3x faster when parsing 2X GBs of recordings.