chore: fix inspector, cleanup loop #2797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2797 will not alter performanceComparing Summary
|
DaniPopes
commented
Jul 24, 2025
| inspector.step_end(interpreter, context); | ||
|
|
||
| if done { | ||
| if interpreter.bytecode.is_end() { |
There was a problem hiding this comment.
idt it matters if is_end calculated before or after step_end, but technically this is now done after
There was a problem hiding this comment.
It should definitely be after step_end. If step_end sets action, it should break the interpreter loop
rakita
reviewed
Jul 25, 2025
Closed
This was referenced Jul 28, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies #2731
Fix missing break after step from #2776