perf: improve inspector loop #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2776 will improve performances by 3.58%Comparing Summary
Benchmarks breakdown
|
DaniPopes
force-pushed
the
inspector-loop
branch
from
5d02750 to
c8f89b4
Compare
rakita
reviewed
Jul 23, 2025
crates/inspector/src/handler.rs
Outdated
| while interpreter.bytecode.is_not_end() { | ||
| // Get current opcode. | ||
| let opcode = interpreter.bytecode.opcode(); | ||
| if interpreter.bytecode.is_not_end() { |
There was a problem hiding this comment.
check for is_not_end can be removed as bytecode will always point to correct opcode.
DaniPopes
force-pushed
the
inspector-loop
branch
from
c8f89b4 to
7cb0d58
Compare
Closed
This was referenced Jul 25, 2025
Closed
Closed
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
Closed
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Majorly simplifies
inspect_instructionsloop to only contain 1 exit and making as small as possible