chore: reuse global crypto provide idea #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2786 will degrade performances by 5.85%Comparing Summary
Benchmarks breakdown
|
DaniPopes
reviewed
Jul 24, 2025
DaniPopes
approved these changes
Jul 24, 2025
DaniPopes
reviewed
Jul 24, 2025
kevaundray
reviewed
Jul 24, 2025
kevaundray
reviewed
Jul 24, 2025
kevaundray
reviewed
Jul 24, 2025
kevaundray
reviewed
Jul 24, 2025
kevaundray
approved these changes
Jul 24, 2025
rakita
force-pushed
the
global-crypto
branch
2 times, most recently
from
e77d3ed to
fa8a709
Compare
This was referenced Jul 25, 2025
Closed
Closed
Closed
This was referenced Jul 25, 2025
This was referenced Aug 4, 2025
Closed
Closed
Closed
Closed
Merged
lwedge99
pushed a commit
to sentioxyz/revm
that referenced
this pull request
Sep 16, 2025
* add bn128 * add rest of impls * add cfg_if * uniform reexport * refactor * nit: function names * remove refs from blake * type alias + inlines * use trait for version hash * remove Result * test dynamic dispatch * revert static call * chore: reuse global crypto provide idea * fix compilation * add default impl to Crypto trait * nit rm alloc * nits * fix lock compilation * return bool for p256 verify fn --------- Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing idea from: #2706
Build on top of: #2777