Removing `kzg-rs` as a dependency

[kevaundray]

Rationale:

Since we now can use arkworks as a no_std alternative and the kzg-rs usecase for zkEVMs can now be satisfied with #2786 -- I believe it is possible to now remove kzg-rs as a dependency.

---

cc @jtguibas and @0xWOLAND to see if there is anything I'm missing here

[mattsse]

I believe @leruaa added this originally

[leruaa]

I don't think this can be removed yet because kzg-rs uses our patched bls12_381, while arkworks uses another lib.

[kevaundray]

I don't think this can be removed yet because kzg-rs uses our patched bls12_381, while arkworks uses another lib.

With #2786 you would still use kzg-rs by implementing the trait and overriding the revm cryptography precompiles

[kevaundray]

So you would implement the Crypto trait and then call this method to override the cryptography precompiles used in revm.

kzg_point_eval for example, would use your custom implementation of Crypto trait using this

This would apply for all of the precompiles, so you should be able to remove the patching mechanism altogether

[leruaa]

Oh I see. So yes I think the kzg-rs dependency could be removed.

[kevaundray]

Planning to wait for a release of revm with the new Crypto trait mechanism mentioned above -- then will remove kzg-rs after, so the breaking change is not bundled in with the new feature (incase something is wrong)

[kevaundray]

@leruaa Have made this PR #2909 -- would be great if you could test out the new interface in rsp though

[leruaa]

Yes I'll have a look early next week

[leruaa]

@kevaundray I'm struggling to test your PR, because in your branch Precompiles::inner() return type is &HashMap<Address, Precompile>, while in Revm v28.0.1 it's expected to be &HashMap<Address, PrecompileFn>.

alloy-evm fail to build because of this. Can you rebase your PR on top of the v85 tag?

[kevaundray]

@kevaundray I'm struggling to test your PR, because in your branch Precompiles::inner() return type is &HashMap<Address, Precompile>, while in Revm v28.0.1 it's expected to be &HashMap<Address, PrecompileFn>.

alloy-evm fail to build because of this. Can you rebase your PR on top of the v85 tag?

Is it possible to test out the released version of revm, with the new precompile feature, to see if everything works as expected even if the kzg-rs feature is disabled?

I believe that if that works, then we could remove kzg-rs in the above PR and it would not change anything on your end

[leruaa]

@kevaundray I did a test with install_crypto() with a custom Crypto in RSP and it worked as expected. I think the PR #2909 can be merged.

[kevaundray]

Thanks!