-
Notifications
You must be signed in to change notification settings - Fork 817
feat: Restucturing Part7 Handler and Context rework #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
Valgrind Results:
|
Closed
Closed
This was referenced Dec 20, 2024
Closed
This was referenced Dec 31, 2024
This was referenced Feb 7, 2025
Closed
Closed
This was referenced Mar 4, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Wodann
reviewed
Mar 21, 2025
Comment on lines
-314
to
-317
if cfg.is_balance_check_disabled() { | ||
// Add transaction cost to balance to ensure execution doesn't fail. | ||
account.info.balance = account.info.balance.saturating_add(balance_check); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was removed. I re-added it in #2286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle becomes list of traits.
Context:
EvmWiring got removed.
cargo depgraph --no-default-features --workspace-only --exclude example-block-traces,example-contract-deployment,example-database-components,example-database-ref,example-uniswap-get-reserves,example-uniswap-v2-usdc-swap | dot -Tpng > graph.png
Graph generated by the command above:
Dependency graph took a good shape. Still needs a lot of cleanup but the major things look really good
InterpreterResult
revm-context
andrevm-handler
are ethereum specific. Not an important decision, and goal should be to clean/merge this asap as it is massive.