Ethereum tests failures when upgrading from revm 9 to 14

[ufoscout]

When upgrading our project from revm 9 to 14, the following tests from the Ethereum suite fail with invalid state root:

ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stRevertTest/RevertPrefoundEmptyCallOOG.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stRevertTest/RevertPrefoundEmptyOOG.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stRevertTest/TouchToEmptyAccountRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stSStoreTest/InitCollision.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stStaticCall/static_call_OOG_additionalGasCosts2.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_CALLCODE_ToEmpty_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_CALLCODE_ToOneStorageKey_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_CALL_ToEmpty_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_CALL_ToOneStorageKey_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_DELEGATECALL_ToEmpty_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_DELEGATECALL_ToOneStorageKey_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_SUICIDE_ToEmpty_OOGRevert.json
ethereum_tests/12.2/BlockchainTests/GeneralStateTests/stZeroCallsRevert/ZeroValue_SUICIDE_ToOneStorageKey_OOGRevert.json

This is the function that executes the transactions:

pub(crate) fn transact_commit_with_inspect<DB>(
    env: Env,
    db: DB,
) -> ExecutionResult
where
    DB: Database + DatabaseCommit,
{
    let mut evm = revm::Evm::builder()
        .with_db(db)
        .with_env_with_handler_cfg(EnvWithHandlerCfg::new_with_spec_id(
            env.into(),
            FORK_SPEC_ID, // Paris fork
        ))
        .append_handler_register(revm::inspector_handle_register)
        .build();

    evm.transact_commit().unwrap() // error handling omitted
}

revm dependency is declared as:

# Using "9.0" works as expected
revm = { version = "14.0", default-features = false, features = [
    "optional_eip3607",
    "serde",
] }

Would you happen to have any clue? Is there anything we should look into? It seems that all failing tests are somehow related to a tx revert

[mattsse]

could be a feature thing, blst, c-kzg

[ufoscout]

Same issue with:

revm = { version = "14.0", default-features = true, features = [
    "serde",
    "arbitrary",
    "asm-keccak",
    "dev",
    "kzg-rs",
] }

[rakita]

There is EIP (https://eips.ethereum.org/EIPS/eip-7610) that changed how an Account is considered empty, in essence, it requires storage to be empty.

In Revm we don't have that check as it is close to impossible to trigger on mainnet as there are only few empty accounts with storage and you would need to get a hash collision to trigger it.

Statetest are handmade with some storage, there is list in Revm here:

revm/bins/revme/src/cmd/statetest/runner.rs

Lines 115 to 125 in e477c7f

	// Test with some storage check.
	| "RevertInCreateInInit_Paris.json"
	| "RevertInCreateInInit.json"
	| "dynamicAccountOverwriteEmpty.json"
	| "dynamicAccountOverwriteEmpty_Paris.json"
	| "RevertInCreateInInitCreate2Paris.json"
	| "create2collisionStorage.json"
	| "RevertInCreateInInitCreate2.json"
	| "create2collisionStorageParis.json"
	| "InitCollision.json"
	| "InitCollisionParis.json"