Skip to content

Conversation

@sergioisidoro
Copy link
Contributor

Fixes #24

Adds support for init_app flask extension style - More details in #24

@twelvelabs
Copy link

@alexchamberlain (or anyone at @bloomberg-oss): is there any chance of this getting merged sometime soon? I'm interested in using this library on a project that uses the flask factory pattern and this would be super helpful. Thanks!

@alexchamberlain
Copy link
Contributor

Apologies for the slow response here - I have updated my notification settings, so that I get notifications from the bloomberg org to my bloomberg address, so hopefully, I'll be more responsive.

On the code itself, I think it looks great - thanks for taking the time to make the change. I've posted 1 additional commit that uses a property instead of a setter. @sergioisidoro Is that OK with you?

On .gitignores, I'll be honest - I'm not a massive fan. I encourage people to use a global .gitignore, especially for editor-specific files. What do you think?

@alexchamberlain
Copy link
Contributor

See also #20 for .gitignore, limited to only those files generated by the repo.

@sergioisidoro
Copy link
Contributor Author

Hi @alexchamberlain.

Yes, of course. Actually that was a TIL, because I've never used that @xx.setter pattern and it looks interesting.

On the .gitignore matter, I have multiple python projects in my local machine, and so the gitignore may vary from project to project (eg. some projects might have the coverage of the latest branch stored in the git). So I'm not a big fan of global gitignores.

This .gitignore is the standard provided by github (https://github.com/github/gitignore/blob/master/Python.gitignore), and I've had no issues with it. But if you feel like #20 makes more sense, go ahead :)

sergioisidoro and others added 2 commits March 6, 2020 11:08
Signed-off-by: Alex Chamberlain <achamberlai9@bloomberg.net>
@alexchamberlain
Copy link
Contributor

Released as 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the package a Flask extention so it can be used with init_app

3 participants