Use property instead of setter

Signed-off-by: Alex Chamberlain <achamberlai9@bloomberg.net>

Author: alexchamberlain

github_webhook/webhook.py

@@ -18,18 +18,23 @@ class Webhook(object):
 
     def __init__(self, app=None, endpoint="/postreceive", secret=None):
         self.app = app
-        self.set_secret(secret)
+        self.secret = secret
         if app is not None:
             self.init_app(app, endpoint, secret)
 
     def init_app(self, app, endpoint="/postreceive", secret=None):
         self._hooks = collections.defaultdict(list)
         self._logger = logging.getLogger("webhook")
         if secret is not None:
-            self.set_secret(secret)
+            self.secret = secret
         app.add_url_rule(rule=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=["POST"])
 
-    def set_secret(self, secret=None):
+    @property
+    def secret(self):
+        return self._secret
+
+    @secret.setter
+    def secret(self, secret):
         if secret is not None and not isinstance(secret, six.binary_type):
             secret = secret.encode("utf-8")
         self._secret = secret

tests/test_webhook.py

@@ -88,7 +88,7 @@ def test_init_app_flow_should_not_accidentally_override_secrets():
     webhook.init_app(app)
 
     # THEN
-    assert webhook._secret is not None
+    assert webhook.secret is not None
 
 
 def test_init_app_flow_should_override_secrets():
@@ -100,7 +100,7 @@ def test_init_app_flow_should_override_secrets():
     webhook.init_app(app, secret="a-new-world-of-secrecy")
 
     # THEN
-    assert webhook._secret == "a-new-world-of-secrecy".encode("utf-8")
+    assert webhook.secret == "a-new-world-of-secrecy".encode("utf-8")
 
 
 def test_run_push_hook(webhook, handler, push_request):