Skip to content

Conversation

@termoshtt
Copy link
Member

Resolve the issue at #48 (comment)

This breaks cargo publish because git-submodule of OpenBLAS is out of CARGO_MANIFEST_DIR. It cannot split from openblas-build introduction #47

OpenBLAS source is included in openblas-src crate, and pass its root path to openblas-build in cargo build of openblas-src. Tests in openblas-build will access to OpenBLAS source through relative path $CARGO_MANIFEST_DIR/../openblas-src/source, thus it does not work if openblas-build is split from this repository. This is a reasonable limitation comparing to include OpenBLAS source both to openblas-src and openblas-build.

@termoshtt termoshtt merged commit 9d074eb into master Jan 17, 2021
@termoshtt termoshtt deleted the source-path-from-src-crate branch January 17, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant