Remove duplicate email import Realtime owner - #519
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change removes email-import Realtime channel management from ChangesEmail import realtime ownership
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This PR removes a duplicate email-import Realtime owner while preserving the existing workspace-scoped invalidation path and tenant filters; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Purpose
Remove the duplicate route-level email-import Realtime owner revealed by governed proof run
31693861981. The existing app-scope workspace invalidation channel already subscribes to both email-import tables and invalidates the shared status query.Included scope
useEmailImportStatusquery-only.useWorkspaceLiveInvalidationas the single persistent, workspace-filtered Realtime owner.Explicit exclusions
Architecture placement
Current owner / directory: existing app-scope workspace invalidation under
src/hooks/useWorkspaceLiveInvalidation.ts; status reads remain undersrc/hooks/useEmailImportStatus.tsx.Dependencies and duplicate-system check: removes a duplicate subsystem and reuses the established persistent workspace invalidation owner.
Security and tenancy impact
workspace_id=eq.<workspace>filters on both backing tables.Data impact
Verification
8/8; network policy and live recorder444/444.--noEmit, Node syntax, and diff checks passed.Governed evidence
Predecessor proof
31693861981on exact mainad8d6ae3275962d2e0e1c5fda14004fcbcfd64b3failed closed at tenant-A Reviews desktop with exact sanitized diagnosticlive_realtime_join_limit_exceeded, topic classemail-import-status, prior stateleave-pending. Cleanup, postflight, and independent recovery passed; writer/readback were skipped and zero proof artifacts were published.Release safety
ad8d6ae3275962d2e0e1c5fda14004fcbcfd64b3, manifest5817ed58921bd91525deacba9f7ee3fb8dad1f60cf0b3866e6c575848af133a4.Documentation and generated files
Completion check
origin/main.Policy exceptions (leave blank when none apply)
PR-size exception rationale: none; five files with a net deletion of duplicate lifecycle machinery.
Retained branch reason / owner / review date / maximum retention date:
Summary by CodeRabbit