Release: integrate fail-closed staging product proof - #381
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds protected staging product-proof execution, deployment and asset binding, browser and database verification, Supabase evidence storage, independent review, shared staging serialization, application fixes, and contract tests. ChangesProduct-proof execution and verification
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant StagingProductProofWorkflow
participant ProductProofDeploymentBinding
participant ProductProofCloudPlaywright
participant SupabaseEvidenceStore
participant IndependentReader
StagingProductProofWorkflow->>ProductProofDeploymentBinding: verify deployment receipt and source marker
StagingProductProofWorkflow->>ProductProofCloudPlaywright: run fixed routes and tenant checks
ProductProofCloudPlaywright->>StagingProductProofWorkflow: write sanitized evidence artifact
StagingProductProofWorkflow->>SupabaseEvidenceStore: upload evidence with writer identity
IndependentReader->>SupabaseEvidenceStore: read back evidence with reader identity
IndependentReader->>StagingProductProofWorkflow: publish pending review receipt
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Purpose
Integrate the fail-closed staging product-proof chain required to earn exact-main authenticated desktop, mobile and accessibility evidence without weakening production, provider, tenant or secret boundaries.
Included scope
structurally_valid_pending_semantic_review.Explicit exclusions
Security and tenancy impact
actions: read/contents: read, no Environment/secrets/provider/staging access, and cannot approve semantic review.Data impact
Verification
3f657711passed CI30696601609, schema baseline30696601610and fresh CodeQL30696600597. Intermediate successorse8ee1991and1cafc745passed CI, schema baseline and CodeQL. CodeRabbit's1cafc745review identified one remaining raw-locator privacy issue; exact successor6126e393removes it with HMAC-only plan replay and has now passed CI, schema baseline, all CodeQL analyses and the CodeRabbit status check.Release safety
Not run.Completion check
origin/main8fb13abfc90450ef3519179356bff3af0424190c.6126e393ce1cc7c380d82521c1cfaa0b9b568a4chas treea0f9d83185e35a28a2cbe5c14fb393ba95f49f98, identical to clean local reviewed head2776a59ca16149f962bb4c2e48adf87fbceaf10b.3f657711passed CI, schema baseline and CodeQL before substantive review.6126e393passed CI, schema baseline, all CodeQL analyses and the CodeRabbit status check.CHANGES_REQUESTEDdecision; verified thread closure/re-review requires separate write authority.Policy exception
This is a 67-file release-evidence unit. The workflow DAG, recorder, exact network/asset policy, synthetic fixture lifecycle, Storage provisioning/readback and source-ownership/security tests form one fail-closed invariant. Independent lanes were developed and reviewed separately, then integrated only after exact-tree compatibility tests passed. Merge remains prohibited until all latest-head protected checks and external stop gates are closed.
Retained branch reason / owner / review date / maximum retention date: none. The release captain will retire the source branch immediately after merge or closure.
Summary by CodeRabbit
New Features
Bug Fixes
Quality
Documentation