-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1139] Flexible collections: deprecate Manage/Edit/Delete Assigned Collections custom permissions #6906
Merged
Merged
[AC-1139] Flexible collections: deprecate Manage/Edit/Delete Assigned Collections custom permissions #6906
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ca1ef99
[AC-1139] Add new layout for MemberDialogComponent when FC feature fl…
r-tome 7ce712a
[AC-1139] Deprecated Organization canEditAssignedCollections, canDele…
r-tome 8e5dc60
[AC-1139] Checking if FC feature flag is enabled when using canDelete…
r-tome 8d2e529
[AC-1139] Added missing parameter to customRedirect
r-tome 4e28fc1
[AC-1139] Fixed canEdit permission
r-tome 12a76a1
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
r-tome 572e6e7
[AC-1139] Fixed CanDelete logic
r-tome 9cac254
[AC-1139] Changed canAccessVaultTab function to receive configService
r-tome f0c25a6
Override deprecated values on sync
eliykat ed9e035
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
r-tome 975d38b
[AC-1139] Reverted change that introduced ConfigService as a paramete…
r-tome e54e614
Merge remote-tracking branch 'origin/ac/ac-1139/deprecate-custom-coll…
r-tome 6484420
[AC-1139] Fixed circular dependency
r-tome c6d8067
[AC-1139] Moved overriding of deprecated values to syncService
r-tome 108de73
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
r-tome 5114eac
Revert "[AC-1139] Fixed circular dependency"
r-tome 8be75ef
Revert "Override deprecated values on sync"
r-tome 33b6930
[AC-1139] Added back the deprecation of methods canEditAssignedCollec…
r-tome 04fb7c0
[AC-1139] Reverted change on syncService
r-tome 9cfe891
[AC-1139] Override deprecated values on sync
r-tome 59d1fe6
[AC-1139] Fix canDelete logic in
r-tome 1c4e73b
[AC-1139] Moved override logic from syncService to organizationService
r-tome efb3195
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
r-tome a97f44a
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
r-tome 9ede0fc
[AC-1139] Add ability to have titlecase titles on nested-checkbox.com…
r-tome 7622c99
Revert "[AC-1139] Add ability to have titlecase titles on nested-chec…
eliykat 561aaf0
[AC-1139] Fix bulk delete functionality
r-tome b9ca4f0
[AC-1139] Refactor canEdit and canDelete to use ternary operator
r-tome 73dcf08
[AC-1139] Fix canDelete condition in VaultComponent
r-tome 8896d81
Merge branch 'master' into ac/ac-1139/deprecate-custom-collection-perm
eliykat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The labels for each custom permission checkbox in Figma all use title case. e.g.
Edit Any Collection
, notEdit any collection
.You may just be able to use the TitleCasePipe to adjust this without updating
messages.json
, which would require re-translations and CrowdIn sync etc.