[AC-1139] Flexible collections: deprecate Manage/Edit/Delete Assigned Collections custom permissions #6906
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 4 findings(s) ✅
- Affected Hotspots: 3 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method bw.ts: Main.constructor 🔥
- Complex Method collection.view.ts: CollectionView.canEdit
✅ Improving Code Health:
- Complex Method vault.component.ts: VaultComponent.deleteCollection 🔥
- Overall Code Complexity vault.component.ts 🔥
- Overall Code Complexity vault.component.ts 🔥
- Complex Method bulk-delete-dialog.component.ts: BulkDeleteDialogComponent.deleteCollections
Annotations
Check warning on line 44 in libs/common/src/vault/models/view/collection.view.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
❌ New issue: Complex Method
CollectionView.canEdit has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
✅ No longer an issue: Complex Method
BulkDeleteDialogComponent.deleteCollections is no longer above the threshold for cyclomatic complexity
Check notice on line 1 in apps/web/src/app/vault/individual-vault/vault.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.73 to 4.70, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 758 in apps/web/src/app/vault/org-vault/vault.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
✅ No longer an issue: Complex Method
VaultComponent.deleteCollection is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in apps/web/src/app/vault/org-vault/vault.component.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.27 to 5.23, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 446 in apps/cli/src/bw.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (master)
❌ Getting worse: Large Method
Main.constructor increases from 271 to 272 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.