Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1461] Secrets Manager seat autoscaling cleanup #5924

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[AC-1461] Secrets Manager seat autoscaling cleanup #5924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6321c3
Remove unused return value from putOrganizationUserBulkEnableSecretsM…
eliykat Jul 31, 2023
e56be11
Update hasResponse
eliykat Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove unused return value from putOrganizationUserBulkEnableSecretsM… 
…anager
  • Loading branch information
@eliykat
eliykat committed Jul 31, 2023
commit a6321c39af12384d75217b8c7bd972594a9b79f3
2 changes: 1 addition & 1 deletion libs/common/src/abstractions/organization-user/organization-user.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export abstract class OrganizationUserService {
abstract putOrganizationUserBulkEnableSecretsManager(
organizationId: string,
ids: string[]
): Promise<ListResponse<OrganizationUserBulkResponse>>;
): Promise<void>;

/**
* Delete an organization user
Expand Down
5 changes: 2 additions & 3 deletions libs/common/src/services/organization-user/organization-user.service.implementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ApiService } from "../../abstractions/api.service";

Check notice on line 1 in libs/common/src/services/organization-user/organization-user.service.implementation.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (feature/sm-billing-round-2)

✅ Getting better: Code Duplication 

reduced similar code in: OrganizationUserServiceImplementation.putOrganizationUserBulkEnableSecretsManager. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
import { OrganizationUserService } from "../../abstractions/organization-user/organization-user.service";
import {
OrganizationUserAcceptInitRequest,
Expand Down Expand Up @@ -209,15 +209,14 @@
async putOrganizationUserBulkEnableSecretsManager(
organizationId: string,
ids: string[]
): Promise<ListResponse<OrganizationUserBulkResponse>> {
const r = await this.apiService.send(
): Promise<void> {
await this.apiService.send(
"PUT",
"/organizations/" + organizationId + "/users/enable-secrets-manager",
new OrganizationUserBulkRequest(ids),
true,
true
);
return new ListResponse(r, OrganizationUserBulkResponse);
}

putOrganizationUser(
Expand Down
Loading