Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1461] Secrets Manager seat autoscaling cleanup #5924

Merged
merged 2 commits into from
Jul 31, 2023

Remove unused return value from putOrganizationUserBulkEnableSecretsM…

a6321c3
Select commit
Loading
Failed to load commit list.
Merged

[AC-1461] Secrets Manager seat autoscaling cleanup #5924

Remove unused return value from putOrganizationUserBulkEnableSecretsM…
a6321c3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (feature/sm-billing-round-2) succeeded Jul 31, 2023 in 44s

CodeScene PR Check

✅ Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

✅ Positive Code Health Impact (highest to lowest):

  • Code Duplication organization-user.service.implementation.ts

Annotations

Check notice on line 1 in libs/common/src/services/organization-user/organization-user.service.implementation.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (feature/sm-billing-round-2)

✅ Getting better: Code Duplication 

reduced similar code in: OrganizationUserServiceImplementation.putOrganizationUserBulkEnableSecretsManager. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis