Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-11588] Bugfix - parse user input value for combined expiry date when creating/adding a card cipher #11103

Merged
merged 10 commits into from
Sep 24, 2024

Merge remote-tracking branch 'origin/main' into pm-11588

5870a1f
Select commit
Loading
Failed to load commit list.
Merged

[PM-11588] Bugfix - parse user input value for combined expiry date when creating/adding a card cipher #11103

Merge remote-tracking branch 'origin/main' into pm-11588
5870a1f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 1s

35.15% (+0.10%) compared to 992964f

View this Pull Request on Codecov

35.15% (+0.10%) compared to 992964f

Details

Codecov Report

Attention: Patch coverage is 96.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (992964f) to head (5870a1f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wser/src/autofill/background/overlay.background.ts 57.14% 3 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts 0.00% 1 Missing ⚠️
...angular/src/vault/components/add-edit.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11103      +/-   ##
==========================================
+ Coverage   35.05%   35.15%   +0.10%     
==========================================
  Files        2711     2712       +1     
  Lines       84576    84661      +85     
  Branches    16069    16093      +24     
==========================================
+ Hits        29649    29766     +117     
+ Misses      53956    53924      -32     
  Partials      971      971

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov