-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-26420] Add flight recorder logs for vault unlock method and PIN migration #6052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt
|
Great job! No new security vulnerabilities introduced in this pull request |
| /** | ||
| * Returns the label for the given [InitUserCryptoMethod]. | ||
| */ | ||
| fun InitUserCryptoMethod.methodName(): String = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not translated, what do you think about converting this to a property and name it logTag, or something similar, so it's clear this should only be used for logging? Would also be good to mention that in the KDocs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes total sense 👍
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6052 +/- ##
==========================================
- Coverage 84.76% 84.75% -0.01%
==========================================
Files 736 737 +1
Lines 55340 55365 +25
Branches 7632 7640 +8
==========================================
+ Hits 46909 46925 +16
- Misses 5763 5767 +4
- Partials 2668 2673 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The base branch was changed.
# Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt # app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt

Note
Depends on PR: #6024
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25990
📔 Objective
Unlock and PIN migration improvements:
migratePinProtectedUserKeyIfNeededinVaultLockManagerImplandderiveTemporaryPinProtectedUserKeyIfNecessaryinVaultRepositoryImplnow accept aninitUserCryptoMethodparameter, allowing them to log and handle the unlock method used.Utility and code organization:
InitUserCryptoMethod.methodName()inInitUserCryptoMethodExtensions.ktto provide human-readable labels for each unlock method, used in logging.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes