Skip to content

Conversation

@andrebispo5
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23290

📔 Objective

Migrates any existing pin keys to a pin protected user key envelope. Existing pins will be migrated when the vault is unlocked. And any new pins will use a pin protected user key envelope on creation.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Logo
Checkmarx One – Scan Summary & Details18f5b552-8bd7-41eb-8356-c8fee4623703

Great job! No new security vulnerabilities introduced in this pull request

# Conflicts:
#	app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt
@andrebispo5 andrebispo5 marked this pull request as ready for review October 15, 2025 15:28
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 86.95652% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.76%. Comparing base (74b9a12) to head (5bb81b0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...arden/data/vault/repository/VaultRepositoryImpl.kt 81.25% 2 Missing and 4 partials ⚠️
...twarden/data/vault/manager/VaultLockManagerImpl.kt 83.33% 0 Missing and 3 partials ⚠️
...en/data/auth/datasource/disk/AuthDiskSourceImpl.kt 87.50% 0 Missing and 2 partials ⚠️
...data/platform/repository/SettingsRepositoryImpl.kt 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6024   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files         737      734    -3     
  Lines       55285    55295   +10     
  Branches     7623     7632    +9     
=======================================
+ Hits        46861    46873   +12     
+ Misses       5764     5754   -10     
- Partials     2660     2668    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrebispo5 andrebispo5 added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit afeeb49 Oct 20, 2025
13 of 15 checks passed
@andrebispo5 andrebispo5 deleted the pm-23290/migrate-pinprotecteduserkey branch October 20, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants