Skip to content

[PM-26750] Allow underscores in Block Autofill URI patterns #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaintPatrck merged 1 commit into from
Oct 9, 2025
Merged

[PM-26750] Allow underscores in Block Autofill URI patterns #6000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...it/bitwarden/ui/platform/feature/settings/autofill/blockautofill/util/StringExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ fun String.validateUri(existingUris: List<String>): Text? {
* Checks if the string matches a specific URI pattern.
*/
fun String.isValidPattern(): Boolean {
val pattern = "^(https?|androidapp)://([A-Za-z0-9-]+(?:\\.[A-Za-z0-9-]+)*)(/.*)?$".toRegex()
val pattern = "^(https?|androidapp)://([A-Za-z0-9_-]+(?:\\.[A-Za-z0-9_-]+)*)(/.*)?$".toRegex()
return matches(pattern)
}
2 changes: 2 additions & 0 deletions ...itwarden/ui/platform/feature/settings/autofill/blockautofill/util/StringExtensionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ class StringExtensionsTest {
"https://a",
"http://a.com",
"https://subdomain.example.com",
"https://example.com/path_with_underscores",
"androidapp://com.example.app",
"androidapp://com.example.app/path_with_underscores",
)

val invalidUris = listOf(
Expand Down
Loading