[PM-26750] Allow underscores in Block Autofill URI patterns #6000
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the regular expression used for validating URIs in the Block Autofill feature to correctly handle underscores. The previous regex did not account for underscores in the domain name or path, causing valid URIs to be incorrectly flagged as invalid. This has been fixed by adding the underscore character (`_`) to the character set in the validation pattern. Additionally, new test cases have been added to `StringExtensionsTest.kt` to verify that URIs containing underscores are now correctly identified as valid patterns.
SaintPatrck
requested review from
a team,
brian-livefront and
david-livefront
as code owners
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
david-livefront
approved these changes
Oct 9, 2025
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6000 +/- ##
==========================================
+ Coverage 84.45% 84.59% +0.13%
==========================================
Files 744 722 -22
Lines 55582 54877 -705
Branches 7576 7568 -8
==========================================
- Hits 46942 46422 -520
+ Misses 5989 5805 -184
+ Partials 2651 2650 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vvolkgang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26750
fixes #5997
📔 Objective
This commit updates the regular expression used for validating URIs in the Block Autofill feature to correctly handle underscores.
The previous regex did not account for underscores in the domain name or path, causing valid URIs to be incorrectly flagged as invalid. This has been fixed by adding the underscore character (
_) to the character set in the validation pattern.Additionally, new test cases have been added to
StringExtensionsTest.ktto verify that URIs containing underscores are now correctly identified as valid patterns.📸 Screenshots
Screen_recording_20251009_132905.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes