-
Notifications
You must be signed in to change notification settings - Fork 927
[PM-26111] Implement Review Export Screen and Navigation #5946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,438
โ12
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
...n/com/x8bit/bitwarden/ui/vault/feature/exportitems/reviewexport/ReviewExportNavigation.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| @file:OmitFromCoverage | ||
|
|
||
| package com.x8bit.bitwarden.ui.vault.feature.exportitems.reviewexport | ||
|
|
||
| import androidx.navigation.NavController | ||
| import androidx.navigation.NavGraphBuilder | ||
| import androidx.navigation.NavOptions | ||
| import com.bitwarden.annotation.OmitFromCoverage | ||
| import com.bitwarden.ui.platform.base.util.composableWithPushTransitions | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| /** | ||
| * The type-safe route for the Review Export screen. | ||
| * | ||
| * This route is used to navigate to the screen where the user can review the items | ||
| * that will be exported from their vault. This screen operates on the currently | ||
| * active user context for determining which items to review for export. | ||
| */ | ||
| @OmitFromCoverage | ||
| @Serializable | ||
| data object ReviewExportRoute | ||
|
|
||
| /** | ||
| * Defines the destination for the Review Export screen within the navigation graph. | ||
| * | ||
| * This extension function on [NavGraphBuilder] sets up the [ReviewExportScreen] | ||
| * composable for the [ReviewExportRoute], using push transitions. | ||
| * | ||
| * @param navController The [NavController] used for handling back navigation from the screen. | ||
| */ | ||
| fun NavGraphBuilder.reviewExportDestination( | ||
| navController: NavController, | ||
| ) { | ||
| composableWithPushTransitions<ReviewExportRoute> { | ||
| ReviewExportScreen( | ||
| onNavigateBack = { navController.popBackStack() }, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Navigates to the Review Export screen. | ||
| * | ||
| * This extension function on [NavController] provides a type-safe way to navigate | ||
| * to the [ReviewExportRoute]. | ||
| * | ||
| * @param navOptions Optional [NavOptions] for this navigation action. | ||
| */ | ||
| fun NavController.navigateToReviewExport( | ||
| navOptions: NavOptions? = null, | ||
| ) { | ||
| navigate(route = ReviewExportRoute, navOptions = navOptions) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐