[PM-26111] Implement Review Export Screen and Navigation #5946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
SaintPatrck
force-pushed
the
cxf/app/export-overview
branch
from
1e8dc37 to
c34d27b
Compare
SaintPatrck
commented
Sep 26, 2025
| val LocalCredentialExchangeCompletionManager: ProvidableCompositionLocal<CredentialExchangeCompletionManager> = | ||
| compositionLocalOf { | ||
| error("CompositionLocal LocalPermissionsManager not present") | ||
| error("CompositionLocal LocalCredentialExchangeCompletionManager not present") |
Contributor
Author
There was a problem hiding this comment.
Fixed this minor copy/paste typo.
| @OmitFromCoverage | ||
| @Serializable | ||
| data object ExportItemsRoute | ||
| data object ExportItemsGraphRoute |
...n/kotlin/com/x8bit/bitwarden/ui/vault/feature/exportitems/reviewexport/ReviewExportScreen.kt
Show resolved
Hide resolved
|
|
||
| @Preview(showBackground = true, name = "Review Export Content") | ||
| @Composable | ||
| private fun ReviewExportContentPreview_WithData() { |
Collaborator
There was a problem hiding this comment.
Can we change this function name to match the pattern. ReviewExportContentWithData_preview
| ), | ||
| ), | ||
| ) | ||
| val handler = ReviewExportHandlers( |
Collaborator
There was a problem hiding this comment.
Can we just define these inline?
...n/kotlin/com/x8bit/bitwarden/ui/vault/feature/exportitems/reviewexport/ReviewExportScreen.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5946 +/- ##
==========================================
+ Coverage 84.36% 84.40% +0.04%
==========================================
Files 737 719 -18
Lines 54827 54764 -63
Branches 7487 7528 +41
==========================================
- Hits 46257 46226 -31
+ Misses 5954 5897 -57
- Partials 2616 2641 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SaintPatrck
force-pushed
the
cxf/app/export-overview
branch
2 times, most recently
from
56b6839 to
e4a7188
Compare
SaintPatrck
requested review from
a team and
brian-livefront
as code owners
| /** | ||
| * Defines events that the [ReviewExportViewModel] can send to the UI. | ||
| */ | ||
| @Stable |
Collaborator
There was a problem hiding this comment.
Do we need this annotation?
SaintPatrck
force-pushed
the
cxf/app/export-overview
branch
from
e4a7188 to
8c81f1c
Compare
SaintPatrck
force-pushed
the
cxf/app/export-overview
branch
from
8c81f1c to
a2f333a
Compare
This commit introduces the "Review Export" screen and its associated navigation logic within the export items flow. This screen displays a snapshot of the types of credentials being exported, along with an expected count of each type. From here, the user can continue to Import credentials from Bitwarden or Cancel. Key changes include: - Added `ReviewExportScreen.kt` to display a summary of items to be exported. - Added `ReviewExportViewModel.kt` to manage the state and logic for the review screen. - Added `ReviewExportHandlers.kt` to manage user interactions on the review screen. - Added `ReviewExportNavigation.kt` to define the navigation route and destination for the review screen. - Integrated the review export screen into the `exportItemsGraph`. - Added new string resources for the review export screen. - Added unit tests for `ReviewExportScreen`, `ReviewExportViewModel`. - Fixed a typo in `LocalCredentialExchangeCompletionManagerProvider.kt`. - Updated `RootNavScreenTest.kt` to use `ExportItemsGraphRoute`.
SaintPatrck
force-pushed
the
cxf/app/export-overview
branch
from
a2f333a to
3caf083
Compare
david-livefront
approved these changes
Sep 29, 2025
Contributor
Author
|
Thanks @david-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-26111
📔 Objective
This commit introduces the "Review Export" screen and its associated navigation logic within the export items flow.
This screen displays a snapshot of the types of credentials being exported, along with an expected count of each type. From here, the user can continue to Import credentials from Bitwarden or Cancel.
Key changes include:
ReviewExportScreen.ktto display a summary of items to be exported.ReviewExportViewModel.ktto manage the state and logic for the review screen.ReviewExportHandlers.ktto manage user interactions on the review screen.ReviewExportNavigation.ktto define the navigation route and destination for the review screen.exportItemsGraph.ReviewExportScreen,ReviewExportViewModel.LocalCredentialExchangeCompletionManagerProvider.kt.RootNavScreenTest.ktto useExportItemsGraphRoute.📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes