Skip to content

PM-26151: Disable continue button for Autofill onboarding flow when autofill is disabled #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-livefront merged 1 commit into from
Sep 24, 2025
Merged

PM-26151: Disable continue button for Autofill onboarding flow when autofill is disabled #5933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ private fun SetupAutoFillContent(
BitwardenFilledButton(
label = stringResource(id = BitwardenString.continue_text),
onClick = onContinueClick,
isEnabled = state.autofillEnabled,
modifier = Modifier
.fillMaxWidth()
.standardHorizontalMargin(),
Expand Down
11 changes: 11 additions & 0 deletions ...c/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupAutofillScreenTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.x8bit.bitwarden.ui.auth.feature.accountsetup

import androidx.compose.ui.test.assertIsDisplayed
import androidx.compose.ui.test.assertIsEnabled
import androidx.compose.ui.test.assertIsNotEnabled
import androidx.compose.ui.test.filterToOne
import androidx.compose.ui.test.hasAnyAncestor
import androidx.compose.ui.test.isDialog
Expand Down Expand Up @@ -77,6 +79,7 @@ class SetupAutofillScreenTest : BitwardenComposeTest() {

@Test
fun `Continue click should send correct action`() {
mutableStateFlow.update { it.copy(autofillEnabled = true) }
composeTestRule
.onNodeWithText("Continue")
.performScrollTo()
Expand Down Expand Up @@ -127,6 +130,14 @@ class SetupAutofillScreenTest : BitwardenComposeTest() {
}
}

@Test
fun `Continue button is enabled according to state`() {
mutableStateFlow.update { it.copy(autofillEnabled = false) }
composeTestRule.onNodeWithText(text = "Continue").assertIsNotEnabled()
mutableStateFlow.update { it.copy(autofillEnabled = true) }
composeTestRule.onNodeWithText(text = "Continue").assertIsEnabled()
}

@Test
fun `Show autofill fallback dialog when dialog state is AutoFillFallbackDialog`() {
mutableStateFlow.update {
Expand Down