Skip to content

Conversation

@david-livefront
Copy link
Collaborator

🎟️ Tracking

PM-26151

📔 Objective

This PR updates the onboarding screen for Autofill to disable the Continue button until the user enabled Autofill. They can still select the Turn on later option.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Logo
Checkmarx One – Scan Summary & Details7f4f3604-0582-407a-b70e-962db3cd4bcc

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront force-pushed the PM-26151-onboarding-autofill-button branch from 0b10cec to 99871ce Compare September 24, 2025 15:59
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.26%. Comparing base (cc685b2) to head (99871ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5933   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         713      713           
  Lines       53690    53691    +1     
  Branches     7401     7401           
=======================================
+ Hits        45244    45245    +1     
  Misses       5851     5851           
  Partials     2595     2595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit e91ba77 Sep 24, 2025
9 checks passed
@david-livefront david-livefront deleted the PM-26151-onboarding-autofill-button branch September 24, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants