-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CollectionView migration #1231
CollectionView migration #1231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will follow up on the issue you're seeing there, maybe with a fresh head now I'll be of some use there, 😉
image = loginIconImage.Item2; | ||
break; | ||
case CipherType.SecureNote: | ||
icon = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these encoded correctly? Just want to ensure the character is still valid/good. IMO would be more clear to use the unicode char code w/ escape character here explicitly defined, or hex representation of that char code, vs. the actual embedded unicode character (which depending on your editor is pretty hard to decipher/check).
@mportune-bw , I notice that in if (!(e.SelectedItem is GroupingsPageListItem item))
{
return;
} I wonder if that has anything to do with the |
@cscharf No dice unfortunately, however this leads me to look at something else possibly connected, so thanks! |
This reverts commit 9876cd5.
* Add passphrase generator options to iOS extension * Set custom indentation on WordSeparator control * Set correct RowsInSection for passphrase controls * Fix RowsInSection for password controls * Add avoid ambiguous characters control
* Expand Hkdf crypto functions * Add tests for hkdf crypto functions Took the testing infrastructure from bitwarden/server * Move Hkdf to cryptoFunctionService * Port changes from bitwarden/jslib#192 * Port changes from bitwarden/jslib#205 * Make Send Expiration Optional implement changes from bitwarden/jslib#242 * Bug fixes found by testing * Test helpers * Test conversion between model types * Test SendService These are mostly happy-path tests to ensure a reasonably correct implementation * Add run tests step to GitHub Actions * Test send decryption * Test Request generation from Send * Constructor dependencies on separate lines * Remove unused testing infrastructure * Rename to match class name * Move fat arrows to previous lines * Handle exceptions in App layer * PR review cleanups * Throw when attempting to save an unkown Send Type I think it's best to only throw on unknown send types here. I don't think we want to throw whenever we encounter one since that would do bad things like lock up Sync if clients get out of date relative to servers. Instead, keep the client from ruining saved data by complaining last minute that it doesn't know what it's doing.
* Fix crash when using yubikey via usb on Android * Fix crash when using usb keyboard on Android
* Send feature for mobile * added fallback for KdfIterations * additional property exclusions for tests * support encryptedFileData as byte array comparison in SendServiceTests * formatting * requested changes * additional changes * change position of send service registration to match declaration order
* additional help text * replace send type picker with segmented control * formatting * added note about rider issue * additional design tweaks
…um (#1261) * Added disabled icon and make File default type for new Sends if premium * forgot to expand colspan for extra icon
* Process UTTypeURL data received from host app * Disable autofill via Share extension for Chrome
* bugfixes * request name focus only if field is empty
* add support for disable send policy * cleanup * show/hide options support for send search results * additional failsafes and copy function consolidation * added missing disabled send icon to android renderer * async fix and string updates
* add Alook browser to autofillservice.xml * add Alook browser to AutofillHelpers.cs * add Alook browser to AccessibilityHelpers.cs, update Via's URL bar
* clear Send password if whitespace * Update SendAddEditPageViewModel.cs
* Remove Url from SendFile. Add file length hit to SendRequest * Populate SendRequest file length
* New translations AppResources.resx (Romanian) * New translations AppResources.resx (Slovak) * New translations AppResources.resx (Latvian) * New translations AppResources.resx (Estonian) * New translations AppResources.resx (Persian) * New translations AppResources.resx (Portuguese, Brazilian) * New translations AppResources.resx (Chinese Traditional) * New translations AppResources.resx (Chinese Simplified) * New translations AppResources.resx (Ukrainian) * New translations AppResources.resx (Turkish) * New translations AppResources.resx (Serbian (Cyrillic)) * New translations AppResources.resx (Russian) * New translations AppResources.resx (Catalan) * New translations AppResources.resx (Polish) * New translations AppResources.resx (Dutch) * New translations AppResources.resx (Korean) * New translations AppResources.resx (Japanese) * New translations AppResources.resx (Italian) * New translations AppResources.resx (Hungarian) * New translations AppResources.resx (Finnish) * New translations AppResources.resx (Danish) * New translations AppResources.resx (Czech)
* Add direct upload api endpoints * Create azure upload service * Update max file size * Update send file upload test * Move internationalization string to correct document * Allow for one shot blob uploads * Remove unused helper * Use FileUploadService Fallback to legacy method on old server implementations.
* Add HideEmail model properties and locale strings * Fix UI strings * Add HideEmail to SendService * Add HideEmail option to UI * Tidy up declarations * Add Bitwarden Send translation warning
* Update Size limits * Add new Api paths for direct upload of Cipher Attachments * Add Attachment upload to fileUploadService * Save with direct upload and fallback to legacy uplaod CipherID is required for direct upload to request an upload URL * Inform on when to remove legacy code * Test Attachment upload
* Android implementation * remove iOS attempt for now
* Deleted appveyor.yml * Remove Include of appveyor.yml from sln-file * Deleted ci-build-apks.ps1 referenced by appveyor.yml * Replaced build badge in README.md
…twarden/mobile into collectionview-conversion
Replaced with #1374 |
Continuation of #934 (new PR due to age of 934 resulting in a lot of diff noise). Screenshots below show Before (L) & After (R) for iOS & Android. Almost pixel perfect but struggling in some areas, possibly due to changes in dip calculations under the hood.
@cscharf I've been defeated by the same NPE you ran into regarding the menu button within the grid item. Everything I've read about
BindingContext
tells me the Cipher should be accessible so something (probably obvious) is still afoot.