Add passphrase generator to iOS Extensions #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
force-pushed
the
passphrase-generator-in-extension
branch
from
990bc2d to
2319ff7
Compare
|
Oh man I can't wait for this one, it's been bugging me since moving to using passphrases. Thanks @eliykat ! |
|
Great work @eliykat, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #620: the iOS autofill and extension password generator does not give the user the options to generate a passphrase.
Edit: I also noticed that the "Avoid ambiguous characters" switch was missing when generating a password, so I added that control as well.
Code changes
iOS.Core/Controllers/PasswordGeneratorViewController.cs.FormEntryTableViewCellandPickerTableViewCellso that we can regenerate the password when their value changesFormEntryTableViewCellobjects - this is required to line it up with the other controls (not sure if there is a better way of doing this)Screenshots
New passphrase controls:
Added "Avoid ambiguous characters" control (note that this now pushes the "Option defaults are set..." text off-screen on an iPhone 12 - not sure if that's worth worrying about):
