Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage Conviva types #106

Merged
merged 25 commits into from
May 21, 2024
Merged

Leverage Conviva types #106

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c088ab6
Expose extended types
karpov-kir May 16, 2024
92be405
Fix tests
karpov-kir May 16, 2024
c260da0
Clean up
karpov-kir May 16, 2024
ecbbf27
Simplify metadata builder
karpov-kir May 16, 2024
1fda763
Update comments
karpov-kir May 16, 2024
582944c
Fix types
karpov-kir May 16, 2024
922edd7
Clean up
karpov-kir May 16, 2024
c41c3dc
Extend comment
karpov-kir May 16, 2024
b0c5b86
Rename a variable
karpov-kir May 16, 2024
8b9e1cb
Fix tests
karpov-kir May 16, 2024
117670e
Fix cleanup
karpov-kir May 16, 2024
f262b50
Update exports
karpov-kir May 17, 2024
40ba99a
Update types
karpov-kir May 17, 2024
5936b5a
Update types
karpov-kir May 17, 2024
2f8e0cc
Update CHANGELOG
karpov-kir May 17, 2024
d710a74
Update types
karpov-kir May 17, 2024
2210ed1
Update CHANGELOG.md
karpov-kir May 17, 2024
bbf4ac8
Fix build
karpov-kir May 17, 2024
a45d751
Clean up
karpov-kir May 17, 2024
cce84d2
Update CHANGELOG.md
karpov-kir May 20, 2024
70cad66
Update a comment
karpov-kir May 20, 2024
c560691
Update a comment
karpov-kir May 20, 2024
06cd739
Add a comment
karpov-kir May 20, 2024
15c36c2
Fix a typo
karpov-kir May 20, 2024
ecc72d4
Update CHANGELOG.md
karpov-kir May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
456 changes: 0 additions & 456 deletions @types/conviva/Conviva.d.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions @types/conviva/index.d.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Deprecated
- Removed `framework` and `frameworkVersion` custom metadata fields (custom tags)
- Removed `CustomContentMetadata`, use `Metadata['custom']` instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these actually be in a ### Removed section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cce84d2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for L14, or not? We missed that there but would be good to clean up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, done here ecc72d4. 🙂


## 4.2.0 - 2023-08-24
### Added
Expand Down
Loading
Loading