Introduce Typescript for only Tests by kenju · Pull Request #13 · bitjourney/react-simple-image

kenju · 2017-05-17T08:12:16Z

This PR

introduces basic configuration for TypeScript ( tsconfig.json )
use ts-node to transpile TypeScript files
use baseOptions/paths compilerOptions along with ts-ndoe
fix failing test only on CI
integrate TypeScript with coverate (nyc)

gfx · 2017-05-17T08:17:32Z

  "files.trimTrailingWhitespace": true,
  "files.autoSave": "onFocusChange",
+  "files.exclude": {
+    "**/.git": true,


デフォルト設定も書く必要あります？

excludeしたいものだけを書くと、上書きではなく追加されるように見えますが。

修正しました 🙏 ->

84e590d

kenju · 2017-05-17T09:45:28Z

@@ -0,0 +1,16 @@
+const tsConfigPaths = require('tsconfig-paths');


[eslint]

Error - Unable to resolve path to module 'tsconfig-paths'. (import/no-unresolved)

kenju · 2017-05-17T09:51:09Z

@@ -0,0 +1,16 @@
+const path = require('path');
+const tsConfigPaths = require('tsconfig-paths');


[eslint]

Error - Unable to resolve path to module 'tsconfig-paths'. (import/no-unresolved)

gfx · 2017-05-17T12:34:59Z

+    "react-dom": "^15.4.1",
+    "source-map-support": "^0.4.15",
+    "ts-node": "^3.0.4",
+    "tsconfig-paths": "^2.1.2",


tsconfig-pathsはなぜ必要なんですか？

ts-node が最初にコンパイルして出力したファイルを実行する時、パス解決をするために必要だからです。

つまり、ts-node と babel-plugin-resolver相当の機能（compulerOptions の baseUrl/paths を組み合わせて設定する）ために、tsconfig-paths が必要ということです。

TypeStrong/ts-node#138 (comment)

tsconfig-paths is not necessary

kenju · 2017-05-18T05:26:13Z

拡張子の件はこのコミットでやりました ->
14e77dd

kenju · 2017-05-18T05:27:39Z

+const originalLoader = Module._load;
+const patchedLoader = (request, parent, isMain) => {
+  try {
+    return originalLoader.call(null, request, parent, isMain);


Node.jsの Module.__load にパッチを当てています　https://github.com/nodejs/node/blob/master/lib/module.js#L432

これが見つからなかったら .jsx 拡張子を当てて再度ロードするようにしています。本体であればいくつかのケースに備えて作る必要がありそうですが、本質的にはこのような解決策でいけそうです。

最終的にすべてのファイルが TypeScript 化し、resolveする必要がなくなったらこのファイルをまるっと消せば良さそうです。

なるほど。いずれ消す前提ならこれでいいと思います。

gfx · 2017-05-18T05:30:31Z

LGTM

kenju · 2017-05-18T05:30:51Z

ありがとうございます 🙏

michiomochi · 2017-05-18T05:32:06Z

👀

kenju changed the title ~~Introduce Typescript for only Tests~~ [WIP] Introduce Typescript for only Tests May 17, 2017

gfx reviewed May 17, 2017

View reviewed changes

kenju commented May 17, 2017

View reviewed changes

kenju force-pushed the typescript branch from 99c78e5 to b5e8a44 Compare May 17, 2017 10:12

introduce TypeScript

4ebf067

kenju force-pushed the typescript branch from b5e8a44 to 4ebf067 Compare May 17, 2017 10:17

forcelly rename src/image.jsx to src/Image.jsx using git mv -f

b562030

gfx reviewed May 17, 2017

View reviewed changes

gfx and others added 2 commits May 18, 2017 10:42

tsconfigh-paths is not necessary

ca03239

fix yarn:coverage to output coverage file

ff89614

gfx mentioned this pull request May 18, 2017

tsconfig-paths is not necessary #14

Merged

gfx and others added 2 commits May 18, 2017 13:04

Merge pull request #14 from bitjourney/use_node_path

4e35dcb

tsconfig-paths is not necessary

add resolver to append .jsx if requested module not found

14e77dd

kenju commented May 18, 2017

View reviewed changes

kenju changed the title ~~[WIP] Introduce Typescript for only Tests~~ Introduce Typescript for only Tests May 18, 2017

kenju merged commit 8fed1e9 into master May 18, 2017

		@@ -0,0 +1,16 @@
		const tsConfigPaths = require('tsconfig-paths');

		@@ -0,0 +1,16 @@
		const path = require('path');
		const tsConfigPaths = require('tsconfig-paths');

Conversation

kenju commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kenju commented May 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfx commented May 18, 2017

Uh oh!

kenju commented May 18, 2017

Uh oh!

michiomochi commented May 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kenju commented May 17, 2017 •

edited

Loading