-
Notifications
You must be signed in to change notification settings - Fork 10
Introduce Typescript for only Tests #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4ebf067
introduce TypeScript
kenju b562030
forcelly rename src/image.jsx to src/Image.jsx using git mv -f
kenju ca03239
tsconfigh-paths is not necessary
gfx ff89614
fix yarn:coverage to output coverage file
kenju 4e35dcb
Merge pull request #14 from bitjourney/use_node_path
gfx 14e77dd
add resolver to append .jsx if requested module not found
kenju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --compilers ts:ts-node/register,tsx:ts-node/register | ||
|
|
||
| --require source-map-support/register | ||
| --require test/resolver.js | ||
|
|
||
| --check-leaks | ||
| --full-trace | ||
| --recursive | ||
| --timeout 1000 | ||
|
|
||
| test/**/*.spec.{ts,tsx} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /* eslint "no-underscore-dangle": "off" */ | ||
| const Module = require('module'); | ||
|
|
||
| const originalLoader = Module._load; | ||
| const patchedLoader = (request, parent, isMain) => { | ||
| try { | ||
| return originalLoader.call(null, request, parent, isMain); | ||
| } catch (error) { | ||
| const newRequest = `${request}.jsx`; | ||
| return originalLoader.call(null, newRequest, parent, isMain); | ||
| } | ||
| }; | ||
| Module._load = patchedLoader; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "allowJs": true, | ||
| "checkJs": false, | ||
| "lib": [ | ||
| "es2015" | ||
| ], | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "noEmitOnError": true, | ||
| "outDir": "build/", | ||
| "baseUrl": "..", | ||
| "paths": { | ||
| "*": [ | ||
| "*" | ||
| ] | ||
| }, | ||
| "removeComments": true, | ||
| "sourceMap": true, | ||
| "strictNullChecks": true, | ||
| "target": "es5", | ||
| "jsx": "react" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.jsの
Module.__loadにパッチを当てています https://github.com/nodejs/node/blob/master/lib/module.js#L432これが見つからなかったら
.jsx拡張子を当てて再度ロードするようにしています。本体であればいくつかのケースに備えて作る必要がありそうですが、本質的にはこのような解決策でいけそうです。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最終的にすべてのファイルが TypeScript 化し、resolveする必要がなくなったらこのファイルをまるっと消せば良さそうです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど。いずれ消す前提ならこれでいいと思います。