Show CalDAV/CardDAV tab when the respective service is present #868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, we showed the
null
address books, which happens when there is no CardDAV service, which caused CardDAV tab shows without detected resources #864).Short description
This PR uses the existence of a CalDAV/CardDAV service as a condition for whether to show the respective tab.
This may cause confusion for users who use servers that report a CalDAV/CardDAV service without providing a Web interface for it. However, they can sometimes still create a collection, which may be want they want.
An alternative would be to just check for
null
and then hide the tab, too. However as said above, they may then never be able to create the first collection on an empty server.Checklist