Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CalDAV/CardDAV tab when the respective service is present #868

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jun 27, 2024

Purpose

Previously, we showed the

Short description

This PR uses the existence of a CalDAV/CardDAV service as a condition for whether to show the respective tab.

This may cause confusion for users who use servers that report a CalDAV/CardDAV service without providing a Web interface for it. However, they can sometimes still create a collection, which may be want they want.

An alternative would be to just check for null and then hide the tab, too. However as said above, they may then never be able to create the first collection on an empty server.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@rfc2822 rfc2822 linked an issue Jun 27, 2024 that may be closed by this pull request
2 tasks
@rfc2822 rfc2822 self-assigned this Jun 27, 2024
@rfc2822 rfc2822 added the bug Something isn't working label Jun 27, 2024
@rfc2822 rfc2822 requested a review from sunkup June 27, 2024 17:40
@rfc2822 rfc2822 force-pushed the 864-carddav-tab-shows-without-detected-resources branch from f56755e to 6f97954 Compare July 1, 2024 09:23
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@rfc2822 rfc2822 merged commit 726e20e into main-ose Jul 1, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 864-carddav-tab-shows-without-detected-resources branch July 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardDAV tab shows without detected resources
2 participants