-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added M3 theme to intro pages #756
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have M2Theme and AppTheme at the same time. We can merge this when all pages are rewritten and then only need AppTheme. I have set appropriate dependencies.
Okay, but why? |
I don't want to need multiple PRs for the same file for the rewrite except it's really required without alternative. But I'd prefer that no files are "in-between", but either "old" or "rewritten/finished". |
74de8dc
to
79545a6
Compare
47ef18b
to
39f8f2e
Compare
(See #691)
Purpose
Right now our M3 theme is not being used for intro pages.
Short description
AppTheme
call inPageFragment
.Checklist
Depends on #739
Depends on #740
Depends on #741
Depends on #757
Depends on #759