Rewrite PermissionsIntroPage to M3 #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
sunkup
requested changes
May 1, 2024
rfc2822
force-pushed
the
main-ose
branch
17 times, most recently
from
47ef18b to
39f8f2e
Compare
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
rfc2822
force-pushed
the
757-rewrite-permissionsintropage-to-m3-→-permissionsactivity
branch
from
91a56f9 to
7836bd7
Compare
rfc2822
approved these changes
May 4, 2024
There was a problem hiding this comment.
I did a few final changes, most notably:
- Observe the lifecycle directly from the Composable, so that
onResumeworks regardless of the Activity where the Screen was embedded from. It also means thatPermissionsActivitydoesn't need to create/pass the model. - M3 buttons are not
uppercase()anymore, please always change that
rfc2822
deleted the
757-rewrite-permissionsintropage-to-m3-→-permissionsactivity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See #691)
Purpose
Update design of the
PermissionsIntroPageintro page (andPermissionsActivity) so that it uses M3.Note
BasicTopAppBarstill has to be migrated to M3. May be good to migrate it together with this PR since it basically has the same considerations asCardWithImage.Short description
PermissionsCardContentCardWithImage.More intro pages will benefit from this change. May have effects on Rewrite DebugInfoActivity to M3 #744, however, I haven't seen any modifications here, and this is a smaller PR, so maybe we should merge this here.
PermissionsActivity.Modelto have private setters.Checklist