Skip to content

Cache LFU drain buffers delegate #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitfaster merged 2 commits into from
Nov 11, 2023
Merged

Cache LFU drain buffers delegate #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c01181
cache del
Nov 11, 2023
edeacad
Merge branch 'main' into users/alexpeck/lfuaction
bitfaster Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion BitFaster.Caching/Lfu/ConcurrentLfu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public sealed class ConcurrentLfu<K, V> : ICache<K, V>, IAsyncCache<K, V>, IBoun
private readonly object maintenanceLock = new();

private readonly IScheduler scheduler;
private readonly Action drainBuffers;

private readonly LfuNode<K, V>[] drainBuffer;

Expand Down Expand Up @@ -110,6 +111,7 @@ public ConcurrentLfu(int concurrencyLevel, int capacity, IScheduler scheduler, I
this.capacity = new LfuCapacityPartition(capacity);

this.scheduler = scheduler;
this.drainBuffers = () => this.DrainBuffers();

this.drainBuffer = new LfuNode<K, V>[this.readBuffer.Capacity];
}
Expand Down Expand Up @@ -532,7 +534,7 @@ private void TryScheduleDrain()
}

this.drainStatus.VolatileWrite(DrainStatus.ProcessingToIdle);
scheduler.Run(() => this.DrainBuffers());
scheduler.Run(this.drainBuffers);
}
}
finally
Expand Down