Skip to content

Cache LFU drain buffers delegate#461

Merged
bitfaster merged 2 commits into
mainfrom
users/alexpeck/lfuaction
Nov 11, 2023
Merged

Cache LFU drain buffers delegate#461
bitfaster merged 2 commits into
mainfrom
users/alexpeck/lfuaction

Conversation

@bitfaster

@bitfaster bitfaster commented Nov 11, 2023

Copy link
Copy Markdown
Owner

Calling drain buffers via the scheduler requires allocating an Action. This shows up when memory profiling the hit rate analysis test:

image
image

Cache the delegate to avoid this allocation. The correct approach would be for IScheduler to accept Action<T>, but that is a breaking change.

@coveralls

coveralls commented Nov 11, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 98.318% (-0.04%) from 98.36%
when pulling edeacad on users/alexpeck/lfuaction
into 0588062 on main.

@bitfaster bitfaster merged commit 23778c2 into main Nov 11, 2023
@bitfaster bitfaster deleted the users/alexpeck/lfuaction branch November 11, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants