Skip to content

bd-resilient-kv: add comprehensive monitoring metrics and tests #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snowp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bd-resilient-kv: add comprehensive monitoring metrics and tests #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions bd-resilient-kv/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ bd-client-stats-store = { path = "../bd-client-stats-store" }
bd-error-reporter = { path = "../bd-error-reporter" }
bd-log = { path = "../bd-log" }
bd-proto = { path = "../bd-proto" }
bd-stats-common = { path = "../bd-stats-common" }
bd-time = { path = "../bd-time" }
bd-workspace-hack.workspace = true
bytes.workspace = true
Expand Down
1 change: 1 addition & 0 deletions bd-resilient-kv/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
use bd_proto::protos::state;

pub mod versioned_kv_store_dynamic_growth_test;
pub mod versioned_kv_store_metrics_test;
pub mod versioned_kv_store_test;
pub mod versioned_recovery_error_test;
pub mod versioned_recovery_test;
Expand Down
6 changes: 3 additions & 3 deletions bd-resilient-kv/src/tests/versioned_kv_store_dynamic_growth_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ async fn insert_triggers_rotation_on_capacity_exceeded() -> anyhow::Result<()> {
#[tokio::test]
async fn insert_fails_when_exceeding_max_capacity() -> anyhow::Result<()> {
use bd_client_stats_store::test::StatsHelper;
use std::collections::BTreeMap;
use bd_stats_common::labels;

let setup = Setup::new();

Expand Down Expand Up @@ -398,8 +398,8 @@ async fn insert_fails_when_exceeding_max_capacity() -> anyhow::Result<()> {
// Verify the metric was incremented
setup.collector.assert_counter_eq(
1,
"test:kv:capacity_exceeded_unrecoverable",
BTreeMap::new(),
"test:kv:capacity_exceeded",
labels!("recoverable" => "false"),
);

Ok(())
Expand Down
Loading
Loading