bd-resilient-kv: add comprehensive monitoring metrics and tests #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metrics for tracking KV store health: - capacity_exceeded (recoverable/unrecoverable) - data_loss (partial/total severity) - journal_open/rotation/sync (success/failure) - compression (success/failure) - rotation_duration_s histogram Add 13 new tests covering all metric scenarios including corruption recovery and capacity handling edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metrics Added
kv:capacity_exceededrecoverable=true/falsekv:data_lossseverity=partial/totalkv:journal_openresult=success/failurekv:journal_rotationresult=success/failurekv:journal_syncresult=success/failurekv:compressionresult=success/failurekv:rotation_duration_sTest Coverage
New test file
versioned_kv_store_metrics_test.rswith 13 tests covering:All 92 tests pass, clippy clean.