fix(cert): add slot_pubkey when verifying satscard signature#43
Merged
notmandatory merged 1 commit intomasterfrom Aug 13, 2025
Merged
fix(cert): add slot_pubkey when verifying satscard signature#43notmandatory merged 1 commit intomasterfrom
notmandatory merged 1 commit intomasterfrom
Conversation
Also fixed pubkey_hash used in cert chain verification to use pubkey.serialize instead of pubkey.serialize_uncompressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #42
Fixed
Certificate::verify_card_signatureby including the slot pubkey in the message digest when verifying a SatsCard.Fixed
Certificate::check_certificateby changing the pubkey hash used in cert chain verification to use pubkey.serialize instead of pubkey.serialize_uncompressed.Notes to the reviewers
I tested these changes with my TapSigner, SatsCard, and SatsChip cards and they all verify now.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: