…scard signature e76fd5e fix(cert): add slot_pubkey when verifying satscard signature (Steve Myers) Pull request description: ### Description fixes bitcoindevkit#42 Fixed `Certificate::verify_card_signature` by including the slot pubkey in the message digest when verifying a SatsCard. Fixed `Certificate::check_certificate` by changing the pubkey hash used in cert chain verification to use pubkey.serialize instead of pubkey.serialize_uncompressed. ### Notes to the reviewers I tested these changes with my TapSigner, SatsCard, and SatsChip cards and they all verify now. ### Changelog notice - Fix certificate chain verification. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/notmandatory/rust-cktap/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR Top commit has no ACKs. Tree-SHA512: 41f55c4880f753d77bdbee7178cf2f3fba9314faa302d5722bc2cc9d4f333702d84ebec16890799bc6314b44f86758ebccac6e2f6c12ffb56b0ccece1d6a904e

CLI certs command is failing for valid cards #42

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

CLI `certs` command is failing for valid cards #42