feat: implement address on SatsCard#39
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jul 31, 2025
Merged
Conversation
| // } | ||
| todo!() | ||
| pub async fn address(&mut self) -> Result<String, Error> { | ||
| // TODO: support testnet |
Member
There was a problem hiding this comment.
AFAIK SATSCARDs and TAPSIGNERs will never support testnet as part of their security policy to prevent people from tricking users into accepting cards with bogus bitcoin.
notmandatory
approved these changes
Jul 31, 2025
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
tACK 6ec21f0
Works with my TAPCARDs thanks for the fix.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement address on SatsCard. Now
cktap-cli addressworks.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing