Skip to content

Comments

feat(cli): add wait commands#41

Merged
notmandatory merged 1 commit intomasterfrom
cli/add_wait_command
Aug 13, 2025
Merged

feat(cli): add wait commands#41
notmandatory merged 1 commit intomasterfrom
cli/add_wait_command

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 7, 2025

Description

I added a cli wait command for TAPSIGNER, SATSCHIP, and SATSCARD to help test recovering from a bad CVC.

Notes to the reviewers

I manually tested the wait command on all three card types. We haven't implemented a cli command for SATSCARD to sign a TX after unwrap ing the private key for a slot so I haven't tested that yet.

Note: The SATSCARD can only sign for UTXOs send to p2wpkh addresses. The SATSCARD reveals the original secret key when a slot is unsealed and that can be used to sign for different script types but it's better to let the card do the signing and to stick with the p2wpkh script type other wallets will use for these cards.

Changelog notice

  • Add cli wait command

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory notmandatory self-assigned this Aug 7, 2025
@notmandatory notmandatory force-pushed the cli/add_wait_command branch from 37f17fc to 5255d72 Compare August 7, 2025 01:28
@notmandatory notmandatory changed the title feat(cli): move address logic to cli, add wait commands feat(cli): add wait commands Aug 13, 2025
@notmandatory notmandatory added the enhancement New feature or request label Aug 13, 2025
@notmandatory notmandatory merged commit 08c4a74 into master Aug 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant