Conversation
37f17fc to
5255d72
Compare
5255d72 to
08c4a74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a cli
waitcommand for TAPSIGNER, SATSCHIP, and SATSCARD to help test recovering from a bad CVC.Notes to the reviewers
I manually tested the
waitcommand on all three card types. We haven't implemented a cli command for SATSCARD to sign a TX afterunwraping the private key for a slot so I haven't tested that yet.Note: The SATSCARD can only sign for UTXOs send to
p2wpkhaddresses. The SATSCARD reveals the original secret key when a slot is unsealed and that can be used to sign for different script types but it's better to let the card do the signing and to stick with thep2wpkhscript type other wallets will use for these cards.Changelog notice
waitcommandChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: