(draft)fix: swift bindings ffi setup#33
Closed
reez wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bunch of changes since #25 that were awesome but swift bindings needed to catch up to them.
#28 solved getting framework to build.
This PR hopefully solves making the framework usable in iOS app again and clean up any unnecessary lines of code.
Tested in iOS app project
Notes to the reviewers
Add --features uniffi to cargo build commands:
Enables the uniffi feature during compilation of each static library to ensure the necessary FFI shim functions defined via #[uniffi::export] are included, fixing linker errors.
Use --manifest-path in uniffi-bindgen:
Generates Swift bindings directly from the Rust crate's Cargo.toml and source code, instead of inspecting a pre-compiled library artifact.
Remove mv commands for headers:
Deletes outdated commands that failed because they tried to move header files based on the previous .udl setup, which are no longer needed as xcodebuild finds the headers correctly elsewhere.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: