Skip to content

Comments

Fixes XCFramework build failure due to misnamed component libraries#28

Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom
aidano:fix_xcframework
Apr 28, 2025
Merged

Fixes XCFramework build failure due to misnamed component libraries#28
notmandatory merged 2 commits intobitcoindevkit:masterfrom
aidano:fix_xcframework

Conversation

@aidano
Copy link
Contributor

@aidano aidano commented Mar 25, 2025

Description

Running the build-xcframework.sh script fails due to a couple of misnamed files. This change fixes that.

Notes to the reviewers

I also updated the version of the rust tooling used for this script.

Changelog notice

Checklists

All Submissions:

  • [x ] I've signed all my commits
  • [x ] I followed the contribution guidelines
  • [x ] I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@upjohnc
Copy link
Contributor

upjohnc commented Apr 2, 2025

@reez : this pr looks like it falls into your domain.

@notmandatory
Copy link
Member

notmandatory commented Apr 21, 2025

@aidano looks like a good cleanup. Please rebase to pickup CI fix in master branch.

@aidano
Copy link
Contributor Author

aidano commented Apr 26, 2025

@notmandatory Done - though GitHub did a merge from master, not a rebase. Let me know if I need to clean that up to remove the merge commit in the PR.

@reez
Copy link
Collaborator

reez commented Apr 28, 2025

Tested ACK 8d532c3

@notmandatory notmandatory added the bug Something isn't working label Apr 28, 2025
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d532c3

@notmandatory notmandatory merged commit b6b7172 into bitcoindevkit:master Apr 28, 2025
6 checks passed
@reez reez mentioned this pull request May 1, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants