Fixes XCFramework build failure due to misnamed component libraries#28
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Apr 28, 2025
Merged
Conversation
Contributor
|
@reez : this pr looks like it falls into your domain. |
Member
|
@aidano looks like a good cleanup. Please rebase to pickup CI fix in master branch. |
Contributor
Author
|
@notmandatory Done - though GitHub did a merge from master, not a rebase. Let me know if I need to clean that up to remove the merge commit in the PR. |
Collaborator
|
Tested ACK 8d532c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running the
build-xcframework.shscript fails due to a couple of misnamed files. This change fixes that.Notes to the reviewers
I also updated the version of the rust tooling used for this script.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: