Skip to content

Run code coverage on every PR #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

Run code coverage on every PR #747

merged 3 commits into from
Sep 12, 2022

Conversation

@danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Sep 9, 2022 •
edited
Loading

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni changed the title WIP: Run code coverage on every PR Run code coverage on every PR Sep 9, 2022
@danielabrozzoni danielabrozzoni marked this pull request as ready for review September 9, 2022 16:09
afilini
afilini approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 49a20df

Waiting for the CI to finish before merging this

@danielabrozzoni
Run code coverage on every PR
1c4d478 
In this way we can check how much of a PR is covered by the tests,
making the review process slightly easier.
@danielabrozzoni danielabrozzoni mentioned this pull request Sep 9, 2022
Closed
4 tasks
@danielabrozzoni
Copy link
Member Author

danielabrozzoni commented Sep 9, 2022 •
edited
Loading

I had to re-push to trigger the CI, but it should be good now 👍🏻

@danielabrozzoni danielabrozzoni self-assigned this Sep 10, 2022
@danielabrozzoni
codecov: slightly change the test features
c3a7bbb 
- Remove default and minimal, as they are redundant
- Use lexicographic order
@danielabrozzoni
codecov: warn about missing features
aa0ea6a
notmandatory
notmandatory approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aa0ea6a

verified PR branch code coverage runs can be found here: https://coveralls.io/github/bitcoindevkit/bdk

afilini
afilini approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aa0ea6a

@afilini afilini merged commit 7b12f35 into bitcoindevkit:master Sep 12, 2022
@afilini afilini mentioned this pull request Oct 7, 2022
Closed
24 tasks
@danielabrozzoni danielabrozzoni deleted the fix/code_coverage_ci branch October 11, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afilini afilini afilini approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels

None yet

Projects

None yet

Milestone

Release 0.23.0 Feature Freeze

Development

Successfully merging this pull request may close these issues.

3 participants

@danielabrozzoni @afilini @notmandatory