Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin.pdf: Add A Page That Lists Translations #839

Merged
merged 2 commits into from
Apr 25, 2015
Merged

Bitcoin.pdf: Add A Page That Lists Translations #839

merged 2 commits into from
Apr 25, 2015

Conversation

harding
Copy link
Contributor

@harding harding commented Apr 23, 2015

Preview: http://dg2.dtrt.org/en/bitcoin-paper

This PR adds a new page to the site listing the original Bitcoin paper as well as all translations available on Bitcoin.org. The PR also updates all existing direct links to the PDF to point to the new page so readers can discover what translations are available.

Note: this PR isn't complete yet---it requires @breathingdog's Spanish translation to be added
once the issues in #822 are resolved. I'll rebase when that's available.

@harding
Copy link
Contributor Author

harding commented Apr 23, 2015

@breathingdog if you can provide a Spanish translation for the following text, I'll add it directly to the PR so it doesn't need to wait for our next Spanish update from Transifex:

summary: "The paper that first introduced Bitcoin"
description: "Satoshi Nakamoto's original paper is still recommended reading for anyone studying how Bitcoin works. Choose which translation of the paper you want to read:"
translated_by: "translated by"
submit_new_translation: 'Do you want to translate the paper into your language? Visit the <a href="/saivann/bitcoinwhitepaper">Bitcoin Paper repository</a> for instructions and <a href="/saivann/bitcoinwhitepaper/issues/new">open an issue</a> if you have any questions.'

@breathingdog
Copy link

I could do a fast translation but always remembering I'm not a pro. The terms "translated_by" or "submit_new_translation" are commands? I suppose they shouldn't be translated, am I wrong?

@harding
Copy link
Contributor Author

harding commented Apr 24, 2015

@breathingdog if you want to leave the translation for the translators on Transifex, that's perfectly fine. The terms before the first colon are keys, so they don't get translated.

@breathingdog
Copy link

summary: "El documento que presentó por primera vez Bitcoin "
decription: "El documento original de Satoshi continúa siendo lectura recomendada para cualquiera que estudie cómo funciona Bitcoin. Escoge qué traducción del documento quieres leer:"
translated_by: "traducido por"
submit_new_translation: "¿Quieres traducir el documento a tu lengua? Para consultar las instrucciones, visita Bitcoin Paper repository y si tienes preguntas, visita: open an issue"

@breathingdog
Copy link

About the last line, it could be also this way, adding "el" before the link to the repository:

"¿Quieres traducir el documento a tu lengua? Para consultar las instrucciones, visita el Bitcoin Paper repository y si tienes preguntas, visita: open an issue"

@harding
Copy link
Contributor Author

harding commented Apr 24, 2015

@breathingdog thanks! I updated the PR and the preview:

@harding harding force-pushed the bitcoin-pdf-translations branch from 894eb9d to 866d072 Compare April 24, 2015 13:05
ghost1542
ghost1542 reviewed Apr 24, 2015
View reviewed changes
_plugins/translate.rb
@@ -87,6 +87,12 @@ def render(context)
text.gsub!("#"+key+"#",'/'+lang+'/'+CGI::escape(value))
end
end

## Hack for renaming links to the Bitcoin paper. Safe to remove
## when all langugages have "bitcoin-paper:" defined in the "url:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harding s/langugages/languages/

@ghost1542
Copy link
Contributor

@harding I suggest we use a single consistent directory for PDF documents, so either we keep them all at the root of the filesystem (/), or we move them all to /files/bitcoin-whitepaper/ , and only keep a copy of the original English whitepaper at the root of the filesystem given how much backlinks this paper currently has.

@harding harding mentioned this pull request Apr 24, 2015
Closed
harding added 2 commits April 24, 2015 14:45
@harding
Move Translated Bitcoin.pdf Files
3302d27 
Move translated bitcoin.pdf files to /files/bitcoin-paper
@harding
Bitcoin.pdf: Create Page Linking To Translations
d383940 
- Adds a new page linking to all translations of Nakamoto's Bitcoin
  paper, and also provides instructions for adding new translations

- Changes all links on the site that used to point directly to the
  English bitcoin.pdf to point to the new page.

- Add Spanish Translation by Breathingdog, as well as Spanish strings
  for the now page also by Breathingdog
@harding harding force-pushed the bitcoin-pdf-translations branch from 866d072 to d383940 Compare April 24, 2015 20:36
@harding
Copy link
Contributor Author

harding commented Apr 24, 2015

Several updates suggested by @saivann (thanks!):

The preview has been updated.

@ghost1542
Copy link
Contributor

@harding Thanks!

@harding
Copy link
Contributor Author

harding commented Apr 24, 2015

In the absence of critical feedback, I'll merge this PR around 23:00 UTC Saturday.

@harding harding merged commit d383940 into bitcoin-dot-org:master Apr 25, 2015
harding added a commit that referenced this pull request Apr 25, 2015
@harding
Merge pulls #839 and #840
400bed4 
* 839: Dev Docs Glossary: Add Denominations Entry
* 840: Bitcoin.pdf: Add A Page That Lists Translations
@harding harding mentioned this pull request Dec 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harding @breathingdog @ghost1542