Skip to content

refactor: Drop redundant setEditTriggers(NoEditTriggers) calls #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2021
Merged

refactor: Drop redundant setEditTriggers(NoEditTriggers) calls #254

merged 1 commit into from
Mar 28, 2021

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Mar 23, 2021

The models of the both views have no Qt::ItemIsEditable flag:

gui/src/qt/peertablemodel.cpp

Lines 218 to 224 in 3c87dbe

Qt::ItemFlags PeerTableModel::flags(const QModelIndex &index) const
{
if (!index.isValid()) return Qt::NoItemFlags;
Qt::ItemFlags retval = Qt::ItemIsSelectable | Qt::ItemIsEnabled;
return retval;
}

gui/src/qt/bantablemodel.cpp

Lines 148 to 154 in 3c87dbe

Qt::ItemFlags BanTableModel::flags(const QModelIndex &index) const
{
if (!index.isValid()) return Qt::NoItemFlags;
Qt::ItemFlags retval = Qt::ItemIsSelectable | Qt::ItemIsEnabled;
return retval;
}

@hebasto
qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls
257f55c 
The models of the both views have no Qt::ItemIsEditable flag.
@hebasto hebasto marked this pull request as draft March 23, 2021 14:40
@hebasto hebasto marked this pull request as ready for review March 23, 2021 14:42
Talkless
Talkless approved these changes Mar 23, 2021
View reviewed changes
Copy link

@Talkless Talkless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 257f55c, seems reasonable.

jarolrod
jarolrod reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 257f55c, looks correct.

Tested for any weird behavior on macOS 11.2.3 Qt 5.15.2

@hebasto hebasto closed this Mar 28, 2021
@hebasto hebasto reopened this Mar 28, 2021
@maflcko maflcko merged commit c008526 into bitcoin-core:master Mar 28, 2021
@hebasto hebasto deleted the 210323-edit branch March 28, 2021 17:34
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 28, 2021
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
6488853 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
564d7b6 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
f574fe8 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
efb73a6 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
ee18eaf 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
26656e8 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
6905d11 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
9188e1f 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
a5c84be 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
@barton2526 barton2526 mentioned this pull request Aug 30, 2021
Merged
gades pushed a commit to cosanta/cosanta-core that referenced this pull request May 9, 2022
@gades
Merge bitcoin-core/gui#254: refactor: Drop redundant setEditTriggers(…
1fbc107 
…NoEditTriggers) calls

257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov)

Pull request description:

  The models of the both views have no `Qt::ItemIsEditable` flag:
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224
  https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154

ACKs for top commit:
  Talkless:
    utACK 257f55c, seems reasonable.
  jarolrod:
    ACK 257f55c, looks correct.

Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge c008526 into merged_master (Bitcoin PR bitcoin-core/gui#254)
79b53ba
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jarolrod jarolrod jarolrod left review comments

@Talkless Talkless Talkless approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hebasto @Talkless @jarolrod @maflcko